allow string dimension indexer to handle byte[] as base64 strings#13573
Merged
kfaraz merged 4 commits intoapache:masterfrom Dec 16, 2022
Merged
allow string dimension indexer to handle byte[] as base64 strings#13573kfaraz merged 4 commits intoapache:masterfrom
kfaraz merged 4 commits intoapache:masterfrom
Conversation
…otobuf byte tests
clintropolis
force-pushed
the
string-dimension-indexer-bytes
branch
from
ee90948 to
09561ca
Compare
kfaraz
pushed a commit
to kfaraz/druid
that referenced
this pull request
Dec 16, 2022
…ache#13573) This PR expands `StringDimensionIndexer` to handle conversion of `byte[]` to base64 encoded strings, rather than the current behavior of calling java `toString`. This issue was uncovered by a regression of sorts introduced by apache#13519, which updated the protobuf extension to directly convert stuff to java types, resulting in `bytes` typed values being converted as `byte[]` instead of a base64 string which the previous JSON based conversion created. While outputting `byte[]` is more consistent with other input formats, and preferable when the bytes can be consumed directly (such as complex types serde), when fed to a `StringDimensionIndexer`, it resulted in an ugly java `toString` because `processRowValsToUnsortedEncodedKeyComponent` is fed the output of `row.getRaw(..)`. Converting `byte[]` to a base64 string within `StringDimensionIndexer` is consistent with the behavior of calling `row.getDimension(..)` which does do this coercion (and why many tests on binary types appeared to be doing the expected thing). I added some protobuf `bytes` tests, but they don't really hit the new `StringDimensionIndexer` behavior because they operate on the `InputRow` directly, and call `getDimension` to validate stuff. The parser based version still uses the old conversion mechanisms, so when not using a flattener incorrectly calls `toString` on the `ByteString`. I have encoded this behavior in the test for now, if we either update the parser to use the new flattener or just .. remove parsers we can remove this test stuff.
kfaraz
added a commit
that referenced
this pull request
Dec 16, 2022
…3573) (#13582) This PR expands `StringDimensionIndexer` to handle conversion of `byte[]` to base64 encoded strings, rather than the current behavior of calling java `toString`. This issue was uncovered by a regression of sorts introduced by #13519, which updated the protobuf extension to directly convert stuff to java types, resulting in `bytes` typed values being converted as `byte[]` instead of a base64 string which the previous JSON based conversion created. While outputting `byte[]` is more consistent with other input formats, and preferable when the bytes can be consumed directly (such as complex types serde), when fed to a `StringDimensionIndexer`, it resulted in an ugly java `toString` because `processRowValsToUnsortedEncodedKeyComponent` is fed the output of `row.getRaw(..)`. Converting `byte[]` to a base64 string within `StringDimensionIndexer` is consistent with the behavior of calling `row.getDimension(..)` which does do this coercion (and why many tests on binary types appeared to be doing the expected thing). I added some protobuf `bytes` tests, but they don't really hit the new `StringDimensionIndexer` behavior because they operate on the `InputRow` directly, and call `getDimension` to validate stuff. The parser based version still uses the old conversion mechanisms, so when not using a flattener incorrectly calls `toString` on the `ByteString`. I have encoded this behavior in the test for now, if we either update the parser to use the new flattener or just .. remove parsers we can remove this test stuff. Co-authored-by: Clint Wylie <cwylie@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR expands
StringDimensionIndexerto handle conversion ofbyte[]to base64 encoded strings, rather than the current behavior of calling javatoString.This issue was uncovered by a regression of sorts introduced by #13519, which updated the protobuf extension to directly convert stuff to java types, resulting in
bytestyped values being converted asbyte[]instead of a base64 string which the previous JSON based conversion created. While outputtingbyte[]is more consistent with other input formats, and preferable when the bytes can be consumed directly (such as complex types serde), when fed to aStringDimensionIndexer, it resulted in an ugly javatoStringbecauseprocessRowValsToUnsortedEncodedKeyComponentis fed the output ofrow.getRaw(..). Convertingbyte[]to a base64 string withinStringDimensionIndexeris consistent with the behavior of callingrow.getDimension(..)which does do this coercion (and why many tests on binary types appeared to be doing the expected thing).I added some protobuf
bytestests, but they don't really hit the newStringDimensionIndexerbehavior because they operate on theInputRowdirectly, and callgetDimensionto validate stuff. The parser based version still uses the old conversion mechanisms, so when not using a flattener incorrectly callstoStringon theByteString. I have encoded this behavior in the test for now, if we either update the parser to use the new flattener or just .. remove parsers we can remove this test stuff.This PR has: