Use correct ObjectMapper in BloomFilterSqlAggregatorTest#13616
Merged
kfaraz merged 1 commit intoapache:25.0.0from Dec 22, 2022
Merged
Use correct ObjectMapper in BloomFilterSqlAggregatorTest#13616kfaraz merged 1 commit intoapache:25.0.0from
kfaraz merged 1 commit intoapache:25.0.0from
Conversation
kfaraz
changed the title
cryptoe
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails consistently locally, both using IDE and from CLI. But hasn't been flagged by Travis even once.
e.g. successful run: https://app.travis-ci.com/github/apache/druid/jobs/591589652#L4131
This has already been fixed on master with #13426 . Not backporting the entirety of those changes as they are not required.
The other usages of
CalciteTests.getJsonMapper()need not be fixed in this branch as they don't seem to be deserializing any object that requires a custom deserializer.