Properly shutdown SQLMetadataSegmentManager and SQLMetadataRuleManager#1366
Merged
xvrl merged 1 commit intoapache:masterfrom May 16, 2015
Merged
Conversation
xvrl
changed the title
Member
|
@drcrallen should we update the rulemanager with the same fix as well? |
drcrallen
force-pushed
the
futurizeSQLMetadataSegmentManager
branch
from
b67abb2 to
74be31a
Compare
drcrallen
changed the title
drcrallen
force-pushed
the
futurizeSQLMetadataSegmentManager
branch
from
74be31a to
e6809ac
Compare
drcrallen
force-pushed
the
futurizeSQLMetadataSegmentManager
branch
from
e6809ac to
051c3cc
Compare
xvrl
added a commit
that referenced
this pull request
May 16, 2015
Properly shutdown SQLMetadataSegmentManager and SQLMetadataRuleManager
Contributor
There was a problem hiding this comment.
Should this emit an alert?
Member
There was a problem hiding this comment.
I believe this is just replicating the existing behavior, which was handled within ScheduledExecutors.scheduleWithFixedDelay
Member
There was a problem hiding this comment.
nothing against having an alert though
Contributor
Author
There was a problem hiding this comment.
I don't think there should be an alert here without a retry strategy. An acute network hiccup should not cause an alert if it is simply recoverable.
Member
There was a problem hiding this comment.
I just realized this error will never get logged, SQLMetadataSegmentManager.poll() already logs and swallows all exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some unit tests I was doing rapid starting and stopping of the SQLMetadataSegmentManager
It was logging errors which did not need to be logged because the tasks were trying to resubmit themselves after the shutdown and failing (as they should). This is not technically an error though, and this PR uses futures to allow killing of the task before shutdown to help minimize false-errors in logs.