Skip to content

Upgrade typescript and other dependencies#13762

Merged
vogievetsky merged 4 commits intoapache:masterfrom
jgoz:upgrade-typescript
Feb 7, 2023
Merged

Upgrade typescript and other dependencies#13762
vogievetsky merged 4 commits intoapache:masterfrom
jgoz:upgrade-typescript

Conversation

@jgoz
Copy link
Copy Markdown
Contributor

@jgoz jgoz commented Feb 7, 2023

Description

Upgrade the following:

  • Typescript to 4.9
  • Zustand to 4.x
  • typescript-eslint to latest

Lint changes:

  • Add 'consistent-type-imports' rule to automatically use import type where possible

Test changes:

  • Drop enzyme for react-shallow-renderer for future proofing since it supports React 18 and enzyme does not/will not
    • The serialized snapshots have some slight differences compared to enzyme, but they largely capture the same details. The big omission is key props, but we can probably live without those.

This PR has:

  • been self-reviewed.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@vogievetsky vogievetsky merged commit b33962c into apache:master Feb 7, 2023
@jgoz jgoz deleted the upgrade-typescript branch February 7, 2023 16:08
abhagraw pushed a commit to abhagraw/druid that referenced this pull request Feb 8, 2023
* Bump zustand, licenses

* Bump TypeScript, Eslint, use type imports

* Switch to react-shallow-renderer from enzyme

* Update ts-loader
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants