Fix NPE in KinesisSupervisor#setupRecordSupplier.#13859
Merged
gianm merged 3 commits intoapache:masterfrom Feb 28, 2023
Merged
Conversation
PR apache#13539 refactored record supplier creation and introduced a bug: this method would throw NPE when recordsPerFetch was not provided by the user. recordsPerFetch isn't needed in this context at all, since the supervisor-side supplier doesn't fetch records. So this patch sets it to zero.
Contributor
|
Not sure why checkstyle is failing with errors in code that's not touched in this PR: |
Contributor
Author
That's an issue with master, will be fixed by #13860. I'll merge that back here when it's committed. |
kfaraz
approved these changes
Feb 28, 2023
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise LGTM
| ioConfig.getAwsExternalId() | ||
| ), | ||
| ioConfig.getRecordsPerFetch(), | ||
| 0, // no records-per-fetch, it is not used |
Contributor
There was a problem hiding this comment.
Maybe rephrase the comment for clarity:
Suggested change
| 0, // no records-per-fetch, it is not used | |
| 0, // need not specify recordsPerFetch as supervisor-side supplier does not fetch records |
Contributor
Author
Thanks for the review. I merged it to avoid the need to re-run CI; would definitely 👍 a PR improving the comment, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13539 refactored record supplier creation and introduced a bug: this method would throw NPE when recordsPerFetch was not provided by the user. recordsPerFetch isn't needed in this context at all, since the supervisor-side supplier doesn't fetch records. So this patch sets it to zero.