fix KafkaInputFormat when used with Sampler API#13900
Merged
gianm merged 3 commits intoapache:masterfrom Mar 9, 2023
Merged
Conversation
gianm
approved these changes
Mar 9, 2023
317brian
pushed a commit
to 317brian/druid
that referenced
this pull request
Mar 10, 2023
* fix KafkaInputFormat when used with Sampler API * handle key format sampling the same as value format sampling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13879.
Description
Fixes issues when using
KafkaInputFormatwith the sampler API. My initial assessment in #13879 was only partially correct. The implementation of thesamplemethod inKafkaInputReaderalso wasn't really correct since by just using the normal read path it did not correctly captureParseExceptionand so would fail immediately. I've adjusted thesamplemethod to delegate to the underlying readerssample, which will correctly handle these, and changed the blending to occur on theInputRowListPlusRawValuesof the underlying sample call instead.Release note
The
KafkaInputFormatnow supports using the sampler API/druid/indexer/v1/sampler.This PR has: