Skip to content

Toward catalog completion#13912

Closed
paul-rogers wants to merge 1 commit intoapache:masterfrom
paul-rogers:230308-catalog
Closed

Toward catalog completion#13912
paul-rogers wants to merge 1 commit intoapache:masterfrom
paul-rogers:230308-catalog

Conversation

@paul-rogers
Copy link
Copy Markdown
Contributor

Breaks out catalog-specific changes from the Catalog Calcite integration PR to allow easier reviewing.

  • Changes catalog table entries to Druid types
  • Enhanced support for external tables, including functions
  • Revised catalog sync API

The key change here is to use Druid types, rather than SQL types, when declaring the schema of a table in the catalog. Druid types better match the actual Druid implementation whereas SQL types are just a SQL "view" on top of the actual Druid types. This change will allow us to use complex types which will be useful for specifying aggregate columns.

Release note

No user-visible changes yet. The docs for the catalog will appear in a later PR after the Calcite integration is complete.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

* Change catalog table entries to Druid types
* Support for external tables, including functions
* Revised catalog sync API
@paul-rogers paul-rogers marked this pull request as draft March 22, 2023 19:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2024

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Feb 9, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2024

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants