Merged
Conversation
…ty to override peon monitors
… class not founds at runtime
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…ests caused by a merge conflict
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| class LogWatchInputStreamTest |
Check notice
Code scanning / CodeQL
Unused classes and interfaces
georgew5656
reviewed
Apr 5, 2023
| @Override | ||
| public void updateStatus(Task task, TaskStatus status) | ||
| { | ||
| log.info("Updating task: %s with status %s", task.getId(), status); |
Contributor
There was a problem hiding this comment.
was this log line left in on purpose?
Contributor
Author
There was a problem hiding this comment.
This was part of the original PR, IMO this should be a debug log.
| .waitUntilCondition( | ||
| x -> (x == null) || (x.getStatus() != null && x.getStatus().getActive() == null), | ||
| x -> (x == null) || (x.getStatus() != null && x.getStatus().getActive() == null | ||
| && (x.getStatus().getFailed() != null || x.getStatus().getSucceeded() != null)), |
Contributor
There was a problem hiding this comment.
this makes sense to me but what was the reasoning for adding this?
9 tasks
abhishekagarwal87
approved these changes
Apr 5, 2023
Contributor
There was a problem hiding this comment.
Reviewed the additional commits on top of the previous PR (#13804) that was already approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Fabric8 version and allow metrics monitors to be overriden
This PR pull in the same code for #13804 and includes the code to upgrade the PodTemplateTaskAdapter.
This PR contains 2 items.
We found that when we used the TaskCountStatsMonitor in the overlord config, the peon tasks would not start because they inherit the monitors from the parent process, which used to be the Middle Manager (but that would never have that monitor originally). So now you can override this value with the following config:
druid.indexer.runner.peonMonitorsRelease note
This PR has: