Fixing overlord unable to become a leader when syncing the lock from metadata store#14038
Merged
cryptoe merged 1 commit intoapache:masterfrom Apr 10, 2023
Merged
Conversation
AmatyaAvadhanula
approved these changes
Apr 10, 2023
cryptoe
added a commit
to cryptoe/druid
that referenced
this pull request
Apr 14, 2023
…metadata store. (apache#14038) (cherry picked from commit 8712098)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlord fails to become the leaders if its encounters an exception while getting the taskLocks from metadatastore.
I saw this problem when one of the clusters was running a MSQ job before this patch: #13282 which changes task priority.
During upgrade, the overlord failed to start due to:
Went ahead and fixed the db sync such that any task groups whose task locks are unable to be synced with the db are first identified.
Post that all the tasks in that task group are killed by the overlord piggy backing on the logic introduced in this patch : #13172
Key changed/added classes in this PR
TaskLockBoxThis PR has: