Skip to content

Add snakeyaml dependency back in#14052

Closed
georgew5656 wants to merge 1 commit intoapache:masterfrom
georgew5656:fixSnakeYaml
Closed

Add snakeyaml dependency back in#14052
georgew5656 wants to merge 1 commit intoapache:masterfrom
georgew5656:fixSnakeYaml

Conversation

@georgew5656
Copy link
Copy Markdown
Contributor

Description

While doing some testing on my other PR (#14030) with the new fabric8 library version, I noticed some snakeyaml error when starting up the overlord. We need to add the snakeyaml library into the pom still as fabric8 6.4.1 still depends on it

This PR has:

  • [X ] been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • [X ] been tested in a test Druid cluster.

Copy link
Copy Markdown
Contributor

@nlippis nlippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@clintropolis
Copy link
Copy Markdown
Member

the dependency checker part of ci seems to be complaining that this dependency is not used, should we just ignore it?

[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ druid-kubernetes-overlord-extensions ---
Warning:  Unused declared dependencies found:
Warning:     org.yaml:snakeyaml:jar:1.33:compile

@georgew5656
Copy link
Copy Markdown
Contributor Author

the dependency checker part of ci seems to be complaining that this dependency is not used, should we just ignore it?


[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ druid-kubernetes-overlord-extensions ---

Warning:  Unused declared dependencies found:

Warning:     org.yaml:snakeyaml:jar:1.33:compile

let me check if updating the version will help, i can see what version of snakeyaml fabric8 uses exactly

@nlippis
Copy link
Copy Markdown
Contributor

nlippis commented Apr 14, 2023

Let's hold off on this change. The reason to put it in was so that the snakeyaml dependency would be included in the bundle. Adding this into the pom does not seem to fix that.

@clintropolis clintropolis removed this from the 26.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants