Add snakeyaml dependency back in#14052
Closed
georgew5656 wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
9 tasks
249f7a7 to
9f6400b
Compare
Member
|
the dependency checker part of ci seems to be complaining that this dependency is not used, should we just ignore it? |
Contributor
Author
let me check if updating the version will help, i can see what version of snakeyaml fabric8 uses exactly |
Contributor
|
Let's hold off on this change. The reason to put it in was so that the snakeyaml dependency would be included in the bundle. Adding this into the pom does not seem to fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While doing some testing on my other PR (#14030) with the new fabric8 library version, I noticed some snakeyaml error when starting up the overlord. We need to add the snakeyaml library into the pom still as fabric8 6.4.1 still depends on it
This PR has: