Input source security feature should work for MSQ tasks#14056
Merged
zachjsh merged 2 commits intoapache:masterfrom Apr 11, 2023
Merged
Input source security feature should work for MSQ tasks#14056zachjsh merged 2 commits intoapache:masterfrom
zachjsh merged 2 commits intoapache:masterfrom
Conversation
Previously msq controller and worker tasks did not have implementations for the `getInputSourceResources()` method. This causes the submission of these tasks to fail if the following auth config is enabled: `druid.auth.enableInputSourceSecurity=true` Added implementations of for these tasks that return an empty set of input sources. This means that for these task types, if `druid.auth.enableInputSourceSecurity=true` config is used, the input source types will be properly computed and authorized in the SQL layer, but not if the equivalent controller / worker tasks are submitted to the task endpoint.
| @Override | ||
| public Set<ResourceAction> getInputSourceResources() | ||
| { | ||
| // the input sources are properly computed in the SQL / calcite layer, but not in the native MSQ task here. |
Contributor
There was a problem hiding this comment.
Actually, thinking about it, should we remove the default implementation that throws an exception in the Task interface? Making the method abstract would force developers to think about the input security model for our different task types from the ground up instead of fixing things because of an unsupported exception at runtime when the feature is enabled. Thoughts?
Contributor
Author
There was a problem hiding this comment.
This only throws an exception by default if a the task is used with the inputSourceType security feature enabled. I think better to default fail than to allow the the usage of the input source unsecured by default. What do you think?
Contributor
There was a problem hiding this comment.
Thanks for clarifying! One more reason why we cannot remove the default implementation is it's a method on a common interface and can break compilation because things can be loaded from custom extensions. So I think having the default behavior is good 👍
Contributor
|
Should we backport this change and #14050 to the 26.0 release? The other input source security changes are in the 26.0 release branch |
zachjsh
added a commit
to zachjsh/druid
that referenced
this pull request
Apr 11, 2023
### Description Previously msq controller and worker tasks did not have implementations for the `getInputSourceResources()` method. This causes the submission of these tasks to fail if the following auth config is enabled: `druid.auth.enableInputSourceSecurity=true` Added implementations of this method for these tasks that return an empty set of input sources. This means that for these task types, if `druid.auth.enableInputSourceSecurity=true` config is used, the input source types will be properly computed and authorized in the SQL layer, but not if the equivalent controller / worker tasks are submitted to the task endpoint.
10 tasks
clintropolis
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Input source security sql layer can handle input source with multiple types (#14050) ### Description This change allows for input sources used during MSQ ingestion to be authorized for multiple input source types, instead of just 1. Such an input source that allows for multiple types is the CombiningInputSource. Also fixed bug that caused some input source specific functions to be authorized against the permissions ` [ new ResourceAction(new Resource(ResourceType.EXTERNAL, ResourceType.EXTERNAL), Action.READ), new ResourceAction(new Resource(ResourceType.EXTERNAL, {input_source_type}), Action.READ) ] ` when the inputSource based authorization feature is enabled, when it should instead be authorized against ` [ new ResourceAction(new Resource(ResourceType.EXTERNAL, {input_source_type}), Action.READ) ] ` * Input source security feature should work for MSQ tasks (#14056) ### Description Previously msq controller and worker tasks did not have implementations for the `getInputSourceResources()` method. This causes the submission of these tasks to fail if the following auth config is enabled: `druid.auth.enableInputSourceSecurity=true` Added implementations of this method for these tasks that return an empty set of input sources. This means that for these task types, if `druid.auth.enableInputSourceSecurity=true` config is used, the input source types will be properly computed and authorized in the SQL layer, but not if the equivalent controller / worker tasks are submitted to the task endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously msq controller and worker tasks did not have implementations for the
getInputSourceResources()method. This causes the submission of these tasks to fail if the following auth config is enabled:druid.auth.enableInputSourceSecurity=trueAdded implementations of this method for these tasks that return an empty set of input sources. This means that for these task types, if
druid.auth.enableInputSourceSecurity=trueconfig is used, the input source types will be properly computed and authorized in the SQL layer, but not if the equivalent controller / worker tasks are submitted to the task endpoint.This PR has: