Register emitter to logger to avoid unit test failures#14180
Merged
clintropolis merged 1 commit intoapache:masterfrom Apr 28, 2023
Merged
Register emitter to logger to avoid unit test failures#14180clintropolis merged 1 commit intoapache:masterfrom
clintropolis merged 1 commit intoapache:masterfrom
Conversation
10 tasks
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
May 1, 2023
clintropolis
added a commit
that referenced
this pull request
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some build failures (https://github.com/apache/druid/actions/runs/4815370013/jobs/8580557362?pr=14175) due to HttpServerInventoryViewTest.testSyncMonitoring. This PR will hopefully fix those flakey test issues.
Description
The test fails occasionally because the test calls serverAdded on three servers and then immediately calls syncMonitoring, assuming that the three recently added servers will be newly synced and the logic in syncMonitoring will skip them.
Calling serverAdded on a server will create a DruidServerHolder for the server and then call start() on the underlying ChangeRequestHttpSyncer object. The start() call will schedule a execution of the sync() method but not guarantee execution before the serverAdded returns. Because of this the unit test can sometimes call syncMonitoring before sync() has been called on all of the ChangeRequestHttpSyncer objects.
This causes serverHolder.syncer.isOK() to return false and eventually leads to the emit call that is failing in the tests.
Release notes
Fix to flaky unit test
Key changed/added classes in this PR
Register a noop emitter so the emit call doesn't fail