Skip to content

update documentation about multiValueHandling#14197

Merged
gianm merged 4 commits intoapache:masterfrom
knorth55:mv-doc-update
May 8, 2023
Merged

update documentation about multiValueHandling#14197
gianm merged 4 commits intoapache:masterfrom
knorth55:mv-doc-update

Conversation

@knorth55
Copy link
Copy Markdown
Contributor

@knorth55 knorth55 commented May 2, 2023

Update documentation about multiValueHandling

Description

I'm a druid beginner, so I'm not super sure, but multiValueHandling param has only effects on string type dimension.
I read source codes and PRs below, and it seems the multiValueHandling sorts only string value.
So I update the doc to add the information about it.
#2541
#10695

I tried to create supervisor with long data with multiValueHandling as ARRAY, but druid always override multiValueHandling as SORTED_ARRAY.
I though it is weird and I read the doc, but doc seems that we can set the value for all types.
I spent long time for this survey, so I want to clarify it in the documents.


Key changed/added classes in this PR
  • docs
  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knorth55 Thanks for your first contribution! Left a suggestion for docs styling.

Comment thread docs/ingestion/ingestion-spec.md Outdated
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Comment thread docs/ingestion/ingestion-spec.md Outdated
Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
Comment thread docs/ingestion/ingestion-spec.md Outdated
@gianm
Copy link
Copy Markdown
Contributor

gianm commented May 8, 2023

thanks 🎉 !

@gianm gianm merged commit 152e937 into apache:master May 8, 2023
@knorth55 knorth55 deleted the mv-doc-update branch May 9, 2023 02:25
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants