fix npe regression in json_value when filtering non-existent paths#14250
Merged
gianm merged 2 commits intoapache:masterfrom May 11, 2023
Merged
fix npe regression in json_value when filtering non-existent paths#14250gianm merged 2 commits intoapache:masterfrom
gianm merged 2 commits intoapache:masterfrom
Conversation
gianm
approved these changes
May 11, 2023
imply-cheddar
approved these changes
May 11, 2023
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
May 11, 2023
…pache#14250) * fix npe regression in json_value when filtering non-existent paths * more coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression caused by #14139 when filtering on non-existent paths with
JSON_VALUE. The (one of the) added test fails without the fix.While I was here, I adjusted the nested column group by query test to skip group-by v1 since this stuff practically doesn't work at all except against string paths on historical segments, which feels like it is effectively unusable, so I just removed them because it was tedious to get the flag combination set correctly, and it cuts down the run time quite a bit.
This PR has: