Skip to content

[Docs] Clean up druid.processing.intermediaryData.storage.type description#14431

Merged
techdocsmith merged 3 commits intoapache:masterfrom
ektravel:deepstore-data-type
Jun 26, 2023
Merged

[Docs] Clean up druid.processing.intermediaryData.storage.type description#14431
techdocsmith merged 3 commits intoapache:masterfrom
ektravel:deepstore-data-type

Conversation

@ektravel
Copy link
Copy Markdown
Contributor

@ektravel ektravel commented Jun 14, 2023

Description

This PR:

  • Adjusts the cell width of tables to improve readability
  • Improves the description of the druid.processing.intermediaryData.storage.type property

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

vtlim
vtlim reviewed Jun 14, 2023
View reviewed changes
Comment thread docs/configuration/index.md Outdated
Comment thread docs/configuration/index.md Outdated
Comment thread docs/configuration/index.md Outdated
@ektravel ektravel requested a review from vtlim June 15, 2023 14:44
techdocsmith
techdocsmith reviewed Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. otherwise LGTM.

Comment thread docs/configuration/index.md Outdated
@ektravel @techdocsmith
Update docs/configuration/index.md
c6cbe0e 
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
techdocsmith
techdocsmith approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit fc08617 into apache:master Jun 26, 2023
@ektravel ektravel deleted the deepstore-data-type branch June 26, 2023 19:39
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
@ektravel @techdocsmith
[Docs] Clean up druid.processing.intermediaryData.storage.type descri…
43ff74c 
…ption (apache#14431)

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtlim vtlim vtlim approved these changes

@techdocsmith techdocsmith techdocsmith approved these changes

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ektravel @vtlim @techdocsmith @abhishekagarwal87