Tasks API documentation refactor#14492
Merged
vtlim merged 15 commits intoapache:masterfrom Jul 11, 2023
Merged
Conversation
vtlim
requested changes
Jun 28, 2023
Member
vtlim
left a comment
vtlim
left a comment
There was a problem hiding this comment.
Great work on this! Left comments on consistency and styling.
abhishekagarwal87
changed the title
vtlim
reviewed
Jun 29, 2023
vtlim
approved these changes
Jul 3, 2023
Member
vtlim
left a comment
vtlim
left a comment
There was a problem hiding this comment.
LGTM. cc @techdocsmith to review also
techdocsmith
requested changes
Jul 6, 2023
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
Great start. Added a few comments/ suggestions.
| @@ -25,77 +25,1565 @@ sidebar_label: Tasks | |||
|
|
|||
| This document describes the API endpoints for task retrieval, submission, and deletion for Apache Druid. | |||
Contributor
There was a problem hiding this comment.
Wonder if a brief definition of a task would be appropriate here. For example: https://druid.apache.org/docs/latest/ingestion/tasks.html
However, in addition to ingestion, I think tasks are going to start doing some of the querying from deep storage work. check with @317brian about those changes
minor style updates/clarifications
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
demo-kratia
added a commit
to demo-kratia/druid
that referenced
this pull request
Jul 27, 2023
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
vtlim
pushed a commit
that referenced
this pull request
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Task API to make easier to browse.
Preview: https://druid-git-tasks-api-refactor-demo-kratia.vercel.app/
This PR has: