Make errorCode of InsertTimeOutOfBoundsFault consistent with others#14495
Merged
zachjsh merged 3 commits intoapache:masterfrom Jul 13, 2023
Merged
Make errorCode of InsertTimeOutOfBoundsFault consistent with others#14495zachjsh merged 3 commits intoapache:masterfrom
zachjsh merged 3 commits intoapache:masterfrom
Conversation
The errorCode of this fault when serialized over the wire was being set to the name of the class `InsertTimeOutOfBoundsFault` instead of the CODE `InsertTimeOutOfBounds`. All other faults' errorCodes are serialized as the respective Fault's code, so making consistent here as well.
Contributor
Author
|
|
|
||
| import java.util.Objects; | ||
|
|
||
| @JsonTypeName(InsertTimeOutOfBoundsFault.CODE) |
Contributor
There was a problem hiding this comment.
Do we have any unit test that tests the serialization/deserialization of this class's wire format?
Contributor
Author
There was a problem hiding this comment.
yes in org.apache.druid.msq.indexing.error.MSQFaultSerdeTest
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
…pache#14495) The errorCode of this fault when serialized over the wire was being set to the name of the class `InsertTimeOutOfBoundsFault` instead of the CODE `InsertTimeOutOfBounds`. All other faults' errorCodes are serialized as the respective Fault's code, so making consistent here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The errorCode of this fault when serialized over the wire was being set to the name of the class
InsertTimeOutOfBoundsFaultinstead of the CODEInsertTimeOutOfBounds. All other faults' errorCodes are serialized as the respective Fault's code, so making consistent here as well. I checked all existing faults at the moment, and this was the only one I found to be inconsistent.This PR has: