Skip to content

Add Continuous Profiling to Unit Tests#14506

Merged
cheddar merged 1 commit intoapache:masterfrom
rash67:profile-tests
Jul 13, 2023
Merged

Add Continuous Profiling to Unit Tests#14506
cheddar merged 1 commit intoapache:masterfrom
rash67:profile-tests

Conversation

@rash67
Copy link
Copy Markdown
Contributor

@rash67 rash67 commented Jun 29, 2023

Description

Uses a custom continuous jfr profiler. Modifies the github actions for tests to do profiling only in the case of jdk17, as the profiler requires jdk17+ to use the JFR streaming API plus a few other language features in the code.

Continuous Profiling service is provided to the Apache Druid project free of charge by Imply and any committer can request free access to the UI.

Release note

No changes to the druid code base, only to how the unit tests are run (javaagent loaded in case of jdk17 unit test runs)


Key changed/added classes in this PR

n/a


This PR has:
  • [ X] been self-reviewed.
  • [X ] added documentation for new or modified features or behaviors.
  • [ X] a release note entry in the PR description.
  • [ X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • [ X] added or updated version, license, or notice information in licenses.yaml
  • [ X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • [ X] added integration tests.
  • [ X] been tested in a test Druid cluster.

@rash67 rash67 force-pushed the profile-tests branch 5 times, most recently from 61c2fc6 to d992d36 Compare June 30, 2023 18:42
@rash67 rash67 force-pushed the profile-tests branch 19 times, most recently from cbdbba5 to ea6e4db Compare July 6, 2023 20:58
Uses a custom continusou jfr profiler.

Modifies the github actions for tests to do profiling only in the case
of jdk17, as the profiler requires jdk17+ to use the JFR streaming API
plus a few other language features in the code.

Continuous Profiling service is provided to the Apache Druid project
free of charge by Imply and any committer can request free access to
the UI.
@cheddar cheddar merged commit 0dcb19f into apache:master Jul 13, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
Uses a custom continusou jfr profiler.

Modifies the github actions for tests to do profiling only in the case
of jdk17, as the profiler requires jdk17+ to use the JFR streaming API
plus a few other language features in the code.

Continuous Profiling service is provided to the Apache Druid project
free of charge by Imply and any committer can request free access to
the UI.
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants