Service status API documentation refactor#14528
Merged
techdocsmith merged 18 commits intoapache:masterfrom Jul 26, 2023
Merged
Conversation
techdocsmith
reviewed
Jul 5, 2023
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
Awesome start! Requested some changes/clarifications
asdf2014
approved these changes
Jul 20, 2023
Member
asdf2014
left a comment
asdf2014
left a comment
There was a problem hiding this comment.
It would be better to format markdown table, others look good to me 🚀
asdf2014
reviewed
Jul 21, 2023
demo-kratia
force-pushed
the
service-status-api-refactor
branch
from
3afa7be to
1a50b91
Compare
ektravel
reviewed
Jul 21, 2023
ektravel
approved these changes
Jul 21, 2023
Contributor
ektravel
left a comment
ektravel
left a comment
There was a problem hiding this comment.
Minor edit to align lines 37 and 38.
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
Contributor
|
@asdf2014 Using a markdown table formatter does not always produce the expected result. To ensure that markdown tables render correctly, we remove any extra space between the columns. |
refine instruction regarding default host/port
demo-kratia
added a commit
to demo-kratia/druid
that referenced
this pull request
Jul 27, 2023
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com> Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com> Co-authored-by: Charles Smith <techdocsmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Service status API documentation to make easier to browse.
Preview: https://druid-git-service-status-api-refactor-demo-kratia.vercel.app/docs/api-reference/service-status-api.html
This PR has: