A query in MSQ would issue wrong error code

[somu-imply]

with a RuntimeException. Now the RuntimeException is being replaced by an user facing DruidException of Invalid category which would allow calcite not to throw an uncategorized exception.

For a query like

insert into test_talaria_test_extern_extern_cols 
select time_parse("time") as __time, * 
from table( 
extern(
'{"type": "s3", "uris": [\"s3://imply-eng-datasets/qa/IngestionTest/wikipedia/files/wikiticker-2015-09-12-sampled.mini.json.gz\"]}',
'{"type\": "json"}',
'[{"name": "time", "type": "string"}, {"name": "channel", "type": "string"}, {"countryName": "string"}]'
)
)
partitioned by DAY
clustered by channel

the query failed like

Error: druidException

Uncategorized calcite error message: [java.lang.RuntimeException: com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `org.apache.druid.segment.column.ColumnSignature`, problem: `java.lang.NullPointerException` at [Source: (String)"[{"name": "time", "type": "string"}, {"name": "channel", "type": "string"}, {"countryName": "string"}]"; line: 1, column: 101] (through reference chain: java.util.ArrayList[2])]

After this change the expected behavior is

Error: druidException

Cannot construct instance of `org.apache.druid.segment.column.ColumnSignature`, problem: `java.lang.NullPointerException` at [Source: (String)"[{"name": "time", "type": "string"}, {"name": "channel", "type": "string"}, {"countryName": "string"}]"; line: 1, column: 101] (through reference chain: java.util.ArrayList[2])

This PR has:

• been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
• added documentation for new or modified features or behaviors.
• a release note entry in the PR description.
• added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
• added or updated version, license, or notice information in licenses.yaml
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
• added integration tests.
• been tested in a test Druid cluster.

[imply-cheddar]

For this one specifically, just so you know, there is an InvalidInput.exception() that you can use. This makes it part of the "invalidInput" group of exceptions instead of the "general" group of exceptions.

[imply-cheddar]

For this case specificaly, it would be great if the original NPE actually carried with it an indication of which field it expected to exist. That is, we likely need to get even deeper and make a better message for the NPE as well.