Skip to content

Fix jackson NPR assertion in JDK 17 #14536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavbhole wants to merge 1 commit into from
Closed

Fix jackson NPR assertion in JDK 17 #14536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import org.apache.druid.sql.calcite.planner.Calcites;
import org.apache.druid.sql.calcite.planner.PlannerContext;
import org.apache.druid.sql.calcite.util.CalciteTests;
import org.apache.druid.utils.JvmUtils;
import org.hamcrest.CoreMatchers;
import org.hamcrest.MatcherAssert;
import org.junit.Assert;
Expand Down Expand Up @@ -1638,6 +1639,9 @@ public void testErrorWithUnableToConstructColumnSignatureWithExtern()
"general"
)
.expectMessageContains(
JvmUtils.majorVersion() >= 17
? "Cannot construct instance of `org.apache.druid.segment.column.ColumnSignature`, problem: Cannot invoke \"String.length()\" because \"s\" is null"
:
Comment on lines +1642 to +1644
Copy link
Copy Markdown
Contributor

@imply-cheddar imply-cheddar Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the source of the exception to do something that doesn't cause NPEs? There's no way that an end user woudl actually understand what s is and why it needs length called on it. Come to think of it, there's probably no reason to believe that they would even understand what an org.apache.druid.segment.column.ColumnSignature is...

"Cannot construct instance of `org.apache.druid.segment.column.ColumnSignature`, problem: Column name must be provided and non-empty"
)
)
Expand Down