Add window query test files from Drill#14561
Merged
cheddar merged 1 commit intoapache:masterfrom Jul 13, 2023
Merged
Conversation
jon-wei
approved these changes
Jul 12, 2023
imply-cheddar
force-pushed
the
all-the-drill-tests
branch
from
944486b to
23751fd
Compare
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the various test files from the Drill tests for window functions. The initial test running stuff was included in #13773 (including the changes to attribute credit to the Drill project for the files) and this PR is just extra test files to feed the tests.
As of this point in time, the results of the tests are largely ignored. Things do run however, but the run of 1000 query tests takes ~13 seconds on my local laptop, so it should not amount to a significant increase in test run times. After these are checked in, we will begin the work of whack-a-moling the issues and making the results actually validated.
Note for reviewers: I'm hoping that since the changes are all in test files and completely located in the
test/resourcesdirectory, the review can simply be one that validates that there are no code changes included in the set of files. Any commentary on the contents of the files is likely to be met with a response of "I didn't change it from what we got from the drill test project, so will look at the content later when working through the tests"