Remove the deprecated InsertCannotOrderByDescending MSQ fault#14588
Merged
LakshSingla merged 2 commits intoapache:masterfrom Jul 17, 2023
Merged
Remove the deprecated InsertCannotOrderByDescending MSQ fault#14588LakshSingla merged 2 commits intoapache:masterfrom
InsertCannotOrderByDescending MSQ fault#14588LakshSingla merged 2 commits intoapache:masterfrom
Conversation
LakshSingla
reviewed
Jul 15, 2023
Contributor
There was a problem hiding this comment.
Now that we are removing the InsertCannotOrderByDescending fault, we should mention in the docs that INSERT with CLUSTERED BY columns in DESC ordering is not allowed. I couldn't find this in the current version from a quick text search, so please ignore it if already mentioned in the docs.
Rest LGTM, thanks for the PR!
LakshSingla
added
the
Area - MSQ
Contributor
Author
|
Good point, @LakshSingla. I've added a note in the |
LakshSingla
approved these changes
Jul 17, 2023
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
…he#14588) The deprecated MSQ fault, InsertCannotOrderByDescending, is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the 27.0 branch is cut out, this PR removes the deprecated MSQ fault
InsertCannotOrderByDescendingas a follow up to #14436 for the next release 28.0.Release note
The deprecated MSQ fault,
InsertCannotOrderByDescending, is removed.This PR has: