new environment vars for external druid and kafka + jupyter template#14592
Merged
techdocsmith merged 4 commits intoapache:masterfrom Jul 25, 2023
Merged
new environment vars for external druid and kafka + jupyter template#14592techdocsmith merged 4 commits intoapache:masterfrom
techdocsmith merged 4 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to parameterize the hostnames for the Kafka and Druid instances such that the jupyter lab environment and its set of notebooks can run on against a variety of deployments. It also standardizes how notebooks are created such that they make use of these environment variables when connecting to Kafka or Druid.
Adjusted the docker compose files to use defaults for
DRUID_VERSION -> defaults to 26.0
DRUID_HOST -> defaults to "router" which works with Druid deployed with the docker compose
KAFKA_HOST -> defaults to "kafka" which works with Kafka deployed with docker compose
Also added a jupyter notebook template @`examples/ that shows how to initialize both kafka and druid host variables in order to make the notebooks work with this parameterized hosts approach.
Using these variables users can use the notebooks on other instances of Druid and/or Kafka.
Examples:
KAFKA_HOST=host.docker.internal DRUID_HOST=host.docker.internal docker compose --profile jupyter up -dDRUID_HOST=host.docker.internal docker compose --profile kafka-jupyter up -ddocker compose --profile all-services up -dThis PR has: