Add support for earliest aggregatorMergeStrategy#14598
Merged
zachjsh merged 5 commits intoapache:masterfrom Jul 18, 2023
Merged
Add support for earliest aggregatorMergeStrategy#14598zachjsh merged 5 commits intoapache:masterfrom
aggregatorMergeStrategy#14598zachjsh merged 5 commits intoapache:masterfrom
Conversation
- More unit tests. - Include the aggregators analysis type by default in tests.
abhishekrb19
force-pushed
the
earliest_agg_strategy
branch
from
aa4e2e1 to
4ed0926
Compare
ektravel
approved these changes
Jul 18, 2023
Contributor
ektravel
left a comment
ektravel
left a comment
There was a problem hiding this comment.
The changes to the documentation look good.
jon-wei
approved these changes
Jul 18, 2023
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
* Add EARLIEST aggregator merge strategy. - More unit tests. - Include the aggregators analysis type by default in tests. * Docs. * Some comments and a test * Collapse into individual code blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
earliestaggregator merge strategy similar to thelatestmerge strategy done in AddaggregatorMergeStrategyproperty in SegmentMetadata queries #14560.SegmentMetadataQueryQueryToolChestTestto include tests for earliest aggregator strategy, a test case for union datasource, and null analysis types.AGGREGATORSanalysis type inSegmentMetadataQueryTestto get more test coverage.Key changed/added classes in this PR
AggregatorMergeStrategy.javaSegmentMetadataQueryQueryToolChest.javaSegmentMetadataQueryQueryToolChestTest.javaRelease note:
aggregatorMergeStrategyalso supports anearliestmerge strategy. Related to #14560.This PR has: