Clean up the core API required for Iceberg extension#14614
Merged
kfaraz merged 3 commits intoapache:masterfrom Jul 21, 2023
Merged
Clean up the core API required for Iceberg extension#14614kfaraz merged 3 commits intoapache:masterfrom
kfaraz merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@a2l007 - Please review. I would like to backport this change to 27 as well. |
kfaraz
approved these changes
Jul 20, 2023
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup!
|
|
||
| /** | ||
| * An interface to generate a {@link SplittableInputSource} objects on the fly. | ||
| * For composing input sources such as IcebergInputSource, the delegate input source instantiation might fail upon deserialization since the input file paths |
Contributor
There was a problem hiding this comment.
Re-reading this part of the comment, I think it is very implementation-specific and shouldn't really be included in the javadoc of this interface.
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
Changes: - Replace `AbstractInputSourceBuilder` with `InputSourceFactory` - Move iceberg specific logic to `IcebergInputSource`
AmatyaAvadhanula
pushed a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
Aug 1, 2023
Changes: - Replace `AbstractInputSourceBuilder` with `InputSourceFactory` - Move iceberg specific logic to `IcebergInputSource`
AmatyaAvadhanula
added a commit
that referenced
this pull request
Aug 1, 2023
* Clean up the core API required for Iceberg extension (#14614) Changes: - Replace `AbstractInputSourceBuilder` with `InputSourceFactory` - Move iceberg specific logic to `IcebergInputSource` * Resolve conflict * Use generic class in tests --------- Co-authored-by: Abhishek Agarwal <1477457+abhishekagarwal87@users.noreply.github.com>
Contributor
|
Thanks for the cleanup @abhishekagarwal87 |
churromorales
pushed a commit
to churromorales/druid
that referenced
this pull request
Sep 13, 2023
Changes: - Replace `AbstractInputSourceBuilder` with `InputSourceFactory` - Move iceberg specific logic to `IcebergInputSource`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It gets rid of the abstract class and now the iceberg extension instead relies on an interface. Some of the logic is moved from the abstract class to IcebergInputSource itself.
This PR has: