Skip to content

Improve logging in CoordinatorBasedSegmentHandoffNotifier #14640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kfaraz merged 5 commits into from
Jul 24, 2023
Merged

Improve logging in CoordinatorBasedSegmentHandoffNotifier #14640

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ffc82a
Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier
Jul 21, 2023
0855050
Log time in ISO 8601
Jul 21, 2023
0d34655
Update pollDuration from long to Duration
Jul 23, 2023
9f397d2
Remove unneeded toString
Jul 23, 2023
af7af8e
Fix checkstyle error
Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...rc/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.query.SegmentDescriptor;
import org.apache.druid.server.coordination.DruidServerMetadata;
import org.joda.time.Duration;

import java.util.Iterator;
import java.util.List;
Expand All @@ -43,7 +44,7 @@ public class CoordinatorBasedSegmentHandoffNotifier implements SegmentHandoffNot
private final ConcurrentMap<SegmentDescriptor, Pair<Executor, Runnable>> handOffCallbacks = new ConcurrentHashMap<>();
private final CoordinatorClient coordinatorClient;
private volatile ScheduledExecutorService scheduledExecutor;
private final long pollDurationMillis;
private final Duration pollDuration;
private final String dataSource;

public CoordinatorBasedSegmentHandoffNotifier(
Expand All @@ -54,7 +55,7 @@ public CoordinatorBasedSegmentHandoffNotifier(
{
this.dataSource = dataSource;
this.coordinatorClient = coordinatorClient;
this.pollDurationMillis = config.getPollDuration().getMillis();
this.pollDuration = config.getPollDuration();
}

@Override
Expand All @@ -80,7 +81,7 @@ public void run()
{
checkForSegmentHandoffs();
}
}, 0L, pollDurationMillis, TimeUnit.MILLISECONDS
}, 0L, pollDuration.getMillis(), TimeUnit.MILLISECONDS
);
}

Expand Down Expand Up @@ -114,10 +115,10 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
"Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs",
"Exception while checking handoff for dataSource[%s] Segment[%s]; will try again after [%s]",
dataSource,
descriptor,
pollDurationMillis
pollDuration
);
}
}
Expand All @@ -128,9 +129,9 @@ void checkForSegmentHandoffs()
catch (Throwable t) {
log.error(
t,
"Exception while checking handoff for dataSource[%s], Will try again after [%d]secs",
"Exception while checking handoff for dataSource[%s]; will try again after [%s]",
dataSource,
pollDurationMillis
pollDuration
);
}
}
Expand Down