Fix Some Typos.#14663
Merged
kfaraz merged 2 commits intoapache:masterfrom Jul 26, 2023
Merged
Conversation
Contributor
Author
|
@kfaraz Can you help review this pr? Thank you very much! |
kfaraz
requested changes
Jul 26, 2023
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for contributing to the docs, @slfan1989 ! There is one change that is not needed, the rest look okay.
| These sorting orders are used by the [TopNMetricSpec](./topnmetricspec.md), [SearchQuery](./searchquery.md), GroupByQuery's [LimitSpec](./limitspec.md), and [BoundFilter](./filters.md#bound-filter). | ||
|
|
||
| ## Lexicographic | ||
| Sorts values by converting Strings to their UTF-8 byte array representations and comparing lexicographically, byte-by-byte. |
Contributor
There was a problem hiding this comment.
This one seems correct to me and need not be changed.
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your help in reviewing this pr! I will revert this change.
kfaraz
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Read some Druid documents, found some typo errors, and fixed them
This PR has: