Skip to content

Fix maxCompletedTasks parameter in OverlordClientImpl. #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Jul 26, 2023
Merged

Fix maxCompletedTasks parameter in OverlordClientImpl. #14667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/druid/rpc/indexing/OverlordClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public ListenableFuture<CloseableIterator<TaskStatusPlus>> taskStatuses(
}

if (maxCompletedTasks != null) {
pathBuilder.append(params == 0 ? '?' : '&').append("maxCompletedTasks=").append(maxCompletedTasks);
pathBuilder.append(params == 0 ? '?' : '&').append("max=").append(maxCompletedTasks);
}

return FutureUtils.transform(
Expand Down
4 changes: 2 additions & 2 deletions server/src/test/java/org/apache/druid/rpc/indexing/OverlordClientImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public void test_taskStatuses_RUNNING_foo_zero() throws Exception
serviceClient.expectAndRespond(
new RequestBuilder(
HttpMethod.GET,
"/druid/indexer/v1/tasks?state=RUNNING&datasource=foo%3F&maxCompletedTasks=0"
"/druid/indexer/v1/tasks?state=RUNNING&datasource=foo%3F&max=0"
),
HttpResponseStatus.OK,
ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
Expand All @@ -203,7 +203,7 @@ public void test_taskStatuses_null_null_zero() throws Exception
serviceClient.expectAndRespond(
new RequestBuilder(
HttpMethod.GET,
"/druid/indexer/v1/tasks?maxCompletedTasks=0"
"/druid/indexer/v1/tasks?max=0"
),
HttpResponseStatus.OK,
ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
Expand Down