Skip to content

Web console: add durable storage selector#14669

Merged
LakshSingla merged 4 commits intoapache:masterfrom
vogievetsky:console_durable_storage
Jul 31, 2023
Merged

Web console: add durable storage selector#14669
LakshSingla merged 4 commits intoapache:masterfrom
vogievetsky:console_durable_storage

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

image

The console work for #14527 and #14629

@vogievetsky vogievetsky added this to the 27.0 milestone Jul 26, 2023
@cryptoe
Copy link
Copy Markdown
Contributor

cryptoe commented Jul 27, 2023

Thanks @vogievetsky for the PR.

  • Should we disable this :
    image when selectDestination=durableStorage

  • Can we have a warning icon when people set selectDestination=taskReport mentioning that its not suited for big results sets and the above limit is applied by default.

Wdyt ?

@vogievetsky
Copy link
Copy Markdown
Contributor Author

Makes total sense!

Copy link
Copy Markdown
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM 🚀
Thanks for adding the functionality in the console.

@LakshSingla LakshSingla merged commit 9e1650e into apache:master Jul 31, 2023
LakshSingla pushed a commit to LakshSingla/druid that referenced this pull request Jul 31, 2023
AmatyaAvadhanula pushed a commit that referenced this pull request Jul 31, 2023
Co-authored-by: Vadim Ogievetsky <vadim@ogievetsky.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants