Skip to content

Quick fix for SegmentLoadDropHandler bug#14670

Merged
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:quickfix_for_segment_loading
Jul 27, 2023
Merged

Quick fix for SegmentLoadDropHandler bug#14670
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:quickfix_for_segment_loading

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Jul 27, 2023

The changes in #14616 seem to be a little buggy and would require thorough testing before we merge them.
Given the urgency of Apache 27 release, this PR is a temporary band-aid which addresses the known bug for the time being.

We can later refine the design in #14616 and perform sufficient testing before merging it.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz added the Bug label Jul 27, 2023
@gianm gianm added this to the 27.0 milestone Jul 27, 2023
@kfaraz kfaraz merged commit 7634ac8 into apache:master Jul 27, 2023
@kfaraz kfaraz deleted the quickfix_for_segment_loading branch July 27, 2023 06:53
@abhishekagarwal87
Copy link
Copy Markdown
Contributor

@kfaraz - can you please backport to 27 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants