Move LookupReferencesManager to ServiceClient.#14691
Closed
gianm wants to merge 6 commits intoapache:masterfrom
Closed
Move LookupReferencesManager to ServiceClient.#14691gianm wants to merge 6 commits intoapache:masterfrom
gianm wants to merge 6 commits intoapache:masterfrom
Conversation
Continuing the work from apache#12696. Also in this patch: 1) Extract the nice request builder stuff from the SeekableStream async client, and put it in a more broadly useful ServiceCallBuilder. 2) Slight behavior change to ServiceClient#request; switch to unchecked get instead of checked get. Unchecked get is more commonly wanted. Callers can get checked get if they need it by using asyncRequest.
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request/issue has been closed due to lack of activity. If you think that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work from #12696. Also in this patch:
Extract the nice request builder stuff from the SeekableStream async
client, and put it in a more broadly useful ServiceCallBuilder.
Slight behavior change to ServiceClient#request; switch to unchecked
get instead of checked get. Unchecked get is more commonly wanted.
Callers can get checked get if they need it by using asyncRequest.