Skip to content

Enable ServiceStatusMonitor in the examples#14744

Merged
suneet-s merged 1 commit intoapache:masterfrom
suneet-s:ssm-enable
Aug 3, 2023
Merged

Enable ServiceStatusMonitor in the examples#14744
suneet-s merged 1 commit intoapache:masterfrom
suneet-s:ssm-enable

Conversation

@suneet-s
Copy link
Copy Markdown
Contributor

@suneet-s suneet-s commented Aug 3, 2023

Description

Enable the ServiceStatusMonitor introduced in #14443 to the list of monitors enabled in the example configurations.

This monitor seems like a good candidate to be enabled by default on clusters. However, I did not see an obvious pattern in the code to enable the monitor in all services by default. So I decided to follow the pattern of enabling the monitor in the common runtime properties instead.

This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader..
  • been tested in a test Druid cluster.

@suneet-s suneet-s merged commit 00f1f8c into apache:master Aug 3, 2023
@suneet-s suneet-s deleted the ssm-enable branch August 3, 2023 13:07
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants