Skip to content

fix(sec): upgrade org.pac4j:pac4j-core to 5.3.1#14787

Closed
ChengDaqi2023 wants to merge 1 commit intoapache:masterfrom
ChengDaqi2023:oscs_fix_cj9km98au51rapcm928g
Closed

fix(sec): upgrade org.pac4j:pac4j-core to 5.3.1#14787
ChengDaqi2023 wants to merge 1 commit intoapache:masterfrom
ChengDaqi2023:oscs_fix_cj9km98au51rapcm928g

Conversation

@ChengDaqi2023
Copy link
Copy Markdown

What happened?

There are 1 security vulnerabilities found in org.pac4j:pac4j-core 3.8.3

What did I do?

Upgrade org.pac4j:pac4j-core from 3.8.3 to 5.3.1 for vulnerability fix

What did you expect to happen?

Ideally, no insecure libs should be used.

How can we automate the detection of these types of issues?

By using the GitHub Actions configurations provided by murphysec, we can conduct automatic code security checks in our CI pipeline.

The specification of the pull request

PR Specification from OSCS

@abhishekagarwal87
Copy link
Copy Markdown
Contributor

@ChengDaqi2023 - can you fix the build failures?

@xvrl
Copy link
Copy Markdown
Member

xvrl commented Dec 15, 2023

upgrading from 3.x to 4.x required some code changes as part of #15522. I would imagine moving to 5.x would also involve more than a version bump. @ChengDaqi2023 do you plan to pick this up again?

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Feb 18, 2024
@abhishekagarwal87
Copy link
Copy Markdown
Contributor

@ChengDaqi2023 - are you still working on this?

@github-actions github-actions Bot removed the stale label Mar 16, 2024
@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label May 15, 2024
@github-actions
Copy link
Copy Markdown

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants