Add uri scheme to S3StorageDruidModule for pullers#1486
Closed
drcrallen wants to merge 1 commit intoapache:masterfrom
Closed
Add uri scheme to S3StorageDruidModule for pullers#1486drcrallen wants to merge 1 commit intoapache:masterfrom
drcrallen wants to merge 1 commit intoapache:masterfrom
Conversation
Merged
Member
There was a problem hiding this comment.
do we need similar changes in all the Storage modules ? I see a separate PR for local storage, what about others, HDFS, cassandra ?
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for future PRs incoming soon