Adjusting SqlStatementResource and SqlTaskResource to set request attribute via a new method.#14878
Merged
LakshSingla merged 3 commits intoapache:masterfrom Aug 26, 2023
Merged
Conversation
10 tasks
LakshSingla
reviewed
Aug 21, 2023
Contributor
LakshSingla
left a comment
LakshSingla
left a comment
There was a problem hiding this comment.
Few nits, PR looks good
| return; | ||
| } | ||
| if (request.getAttribute(AuthConfig.DRUID_AUTHORIZATION_CHECKED) != null) { | ||
| throw new ISE("Request already had authorization check."); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new ISE("Request already had authorization check."); | |
| throw DruidException.defensive("Request already had authorization check."); |
| public static void setRequestAuthorizationAttributeIfNeeded(final HttpServletRequest request) | ||
| { | ||
| if (request.getAttribute(AuthConfig.DRUID_ALLOW_UNSECURED_PATH) != null) { | ||
| // do nothing |
Contributor
There was a problem hiding this comment.
Seems shallow, can you please expand on this or remove the comment?
LakshSingla
approved these changes
Aug 26, 2023
Contributor
LakshSingla
left a comment
LakshSingla
left a comment
There was a problem hiding this comment.
Thanks for the PR! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusting
SqlStatementResourceandSqlTaskResourceto set request attribute via a new method in AuthUtils which sets the request attribute since we donot have anyResourcesto validate against.Please note that this PR is a code readability change and does not effect the functionality of both these API's.
This was one of the feedback for : #14416