Remove segmentsToBeDropped from SegmentTransactionInsertAction#14883
Merged
kfaraz merged 2 commits intoapache:masterfrom Aug 21, 2023
Merged
Remove segmentsToBeDropped from SegmentTransactionInsertAction#14883kfaraz merged 2 commits intoapache:masterfrom
kfaraz merged 2 commits intoapache:masterfrom
Conversation
AmatyaAvadhanula
approved these changes
Aug 21, 2023
Contributor
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
LGTM, @kfaraz! +1 after all the checks pass
Contributor
Author
|
Thanks for the prompt review, @AmatyaAvadhanula ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no usage of the
SegmentTransactionInsertActionwhich passes a non-null non-empty value ofsegmentsToBeDropped.This is not really needed either as overshadowed segments are marked as unused by the Coordinator and need not be done in the same transaction as committing segments.
This will also help simplify the changes being made in #14407
Changes
segmentsToBeDroppedfrom the task action and all methods that have just been passing nullThis PR has: