Remove deprecated coordinator dynamic configs#14923
Merged
kfaraz merged 2 commits intoapache:masterfrom Sep 4, 2023
Merged
Conversation
Contributor
Author
|
Thanks for the review, @AmatyaAvadhanula ! |
jakubmatyszewski
pushed a commit
to jakubmatyszewski/druid
that referenced
this pull request
Sep 8, 2023
Changes: [A] Remove config `decommissioningMaxPercentOfMaxSegmentsToMove` - It is a complicated config 😅 , - It is always desirable to prioritize move from decommissioning servers so that they can be terminated quickly, so this should always be 100% - It is already handled by `smartSegmentLoading` (enabled by default) [B] Remove config `maxNonPrimaryReplicantsToLoad` This was added in apache#11135 to address two requirements: - Prevent coordinator runs from getting stuck assigning too many segments to historicals - Prevent load of replicas from competing with load of unavailable segments Both of these requirements are now already met thanks to: - Round-robin segment assignment - Prioritization in the new coordinator - Modifications to `replicationThrottleLimit` - `smartSegmentLoading` (enabled by default)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove config
decommissioningMaxPercentOfMaxSegmentsToMovesmartSegmentLoading(enabled by default)Remove config
maxNonPrimaryReplicantsToLoadThis was added in #11135 to address two requirements:
Both of these requirements are now already met thanks to:
replicationThrottleLimit: ThereplicationThrottleLimitnow ensures that for any tier, the sum of the number of replicas in load queue at start of a coordinator run and the number of replicas assigned during the run is always within the limit. So, it can perform the same function asmaxNonPrimaryReplicantsToLoadexceptreplicationThrottleLimitis per tier.smartSegmentLoading(enabled by default) takes care of all of the above without requiring the user to change any configPending
Release note
Remove deprecated coordinator dynamic configs:
decommissioningMaxPercentOfMaxSegmentsToMovemaxNonPrimaryReplicantsToLoadThese configs are not needed anymore as
smartSegmentLoadingautomatically ensures the optimal behaviour in the underlying scenarios.This PR has: