Skip to content

Configure FunctionArgsAlignmentRule#14937

Closed
kgyrtkirk wants to merge 16 commits intoapache:masterfrom
kgyrtkirk:checkstyle-x
Closed

Configure FunctionArgsAlignmentRule#14937
kgyrtkirk wants to merge 16 commits intoapache:masterfrom
kgyrtkirk:checkstyle-x

Conversation

@kgyrtkirk
Copy link
Copy Markdown
Member

@kgyrtkirk kgyrtkirk commented Sep 1, 2023

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

github-advanced-security[bot]
github-advanced-security AI found potential problems Sep 1, 2023
View reviewed changes
Comment thread processing/src/test/java/org/apache/druid/java/util/common/CompressionUtilsTest.java
};

Assert.assertEquals((long) (EXPECTED.length * 3), CompressionUtils.gunzip(inputStreamFactory, testFile).size());
Assert.assertEquals(EXPECTED.length * 3, CompressionUtils.gunzip(inputStreamFactory, testFile).size());

Check warning

Code scanning / CodeQL

Result of multiplication cast to wider type

Potential overflow in [int multiplication](1) before it is converted to long by use in an invocation context.
Comment thread sql/src/main/java/org/apache/druid/sql/calcite/filtration/MoveTimeFiltersToIntervals.java
return Range.range(
Long.parseLong(range.lowerEndpoint().getValue()), range.lowerBoundType(),
Long.parseLong(range.upperEndpoint().getValue()), range.upperBoundType()
Long.parseLong(range.lowerEndpoint().getValue()),

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
Comment thread sql/src/main/java/org/apache/druid/sql/calcite/filtration/MoveTimeFiltersToIntervals.java
Long.parseLong(range.upperEndpoint().getValue()), range.upperBoundType()
Long.parseLong(range.lowerEndpoint().getValue()),
range.lowerBoundType(),
Long.parseLong(range.upperEndpoint().getValue()),

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
@kgyrtkirk kgyrtkirk mentioned this pull request Oct 28, 2023
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2024

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Mar 4, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2024

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kgyrtkirk @github-advanced-security