Rename IMSC.announceHistoricalSegments to commitSegments#15021
Merged
kfaraz merged 1 commit intoapache:masterfrom Sep 21, 2023
Merged
Rename IMSC.announceHistoricalSegments to commitSegments#15021kfaraz merged 1 commit intoapache:masterfrom
kfaraz merged 1 commit intoapache:masterfrom
Conversation
| newSegment(Intervals.of("2019-04-01/2019-05-01"), version) | ||
| ); | ||
| final Set<DataSegment> announced = getMetadataStorageCoordinator().announceHistoricalSegments(segments); | ||
| final Set<DataSegment> announced = getMetadataStorageCoordinator().commitSegments(segments); |
Contributor
There was a problem hiding this comment.
It might be nice to rename announced to committed
Contributor
Author
There was a problem hiding this comment.
Sure 👍🏻
If CI fails for any reason, I will include this change. Otherwise, I will include it in the other PR.
AmatyaAvadhanula
approved these changes
Sep 21, 2023
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
LGTM except for a minor suggestion. +1 after all checks have passed
Contributor
Author
|
Merging as IT failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pulls out some changes from #14407 to simplify that PR
Changes
IndexerMetadataStorageCoordinator.announceHistoricalSegmentstocommitSegmentscommitSegmentsAndMetadata