Added UI support for waitTillSegmentsLoad#15110
Added UI support for waitTillSegmentsLoad#15110abhishekagarwal87 merged 5 commits intoapache:masterfrom
Conversation
lorem--ipsum
force-pushed
the
waitTillSegmentsLoad-ui
branch
from
a00c515 to
0635acc
Compare
adarshsanjeev
left a comment
adarshsanjeev
left a comment
There was a problem hiding this comment.
Thanks for the PR! The changes look good, but I had a few suggestions
| public getSegmentStatusDescription() { | ||
| const { segmentStatus } = this; | ||
|
|
||
| switch (segmentStatus) { |
There was a problem hiding this comment.
Could this also display the segments breakdown after ingestion? This information should be available in the same place
"totalSegments": 1,
"usedSegments": 1,
"precachedSegments": 0,
"onDemandSegments": 0,
There was a problem hiding this comment.
We should also show the time for the query part and ingestion part separately, so that any user can know the actual time taken for the query and won't mistake it as druid being slow. This information should also be available in segmentLoadStatus and its parent object.
|
I think we should also disable the current sql check, since it would be no longer needed |
|
Thanks for the feedback, I've added mroe details in the "Details" dialog: |
adarshsanjeev
left a comment
adarshsanjeev
left a comment
There was a problem hiding this comment.
Thanks for the changes!
This relies on the work done in apache#14322 and apache#15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI :
This relies on the work done in apache#14322 and apache#15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI :
This relies on the work done in apache#14322 and apache#15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI :
4 participants
This relies on the work done in #14322 and #15076. It allows the user to set
waitTillSegmentsLoadin the query context (if they want, else it defaults totrue) and shows the results in the UI :