Make CliPeon run shutdown hooks properly#1524
Merged
fjy merged 1 commit intoapache:masterfrom Jul 15, 2015
Merged
Conversation
Contributor
|
👍 |
Member
There was a problem hiding this comment.
is there a reason we need to shut down the jetty server separately? It should get stopped as part of the lifecycle.
Contributor
Author
There was a problem hiding this comment.
Was resolved in person. Related to daemon thread-ness of jetty thread pool.
Member
|
@drcrallen it should be enough to just make the Jetty query thread pool to use daemon threads, so we don't have to worry about it outside of the lifecycle. |
Contributor
Author
|
Fixed jetty to have daemon threads and allow cleaner shutdown |
Member
There was a problem hiding this comment.
this is not needed anymore, is it?
Contributor
Author
There was a problem hiding this comment.
not mine! will fix anyways
* Also make jetty threads daemon
Contributor
Author
|
Test failed on zk consistency issues. Restarting |
Member
|
👍 |
fjy
added a commit
that referenced
this pull request
Jul 15, 2015
Make CliPeon run shutdown hooks properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.