Fix an issue with passing order by and limit to realtime tasks#15301
Merged
cryptoe merged 4 commits intoapache:masterfrom Nov 2, 2023
Merged
Fix an issue with passing order by and limit to realtime tasks#15301cryptoe merged 4 commits intoapache:masterfrom
cryptoe merged 4 commits intoapache:masterfrom
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
LakshSingla
reviewed
Nov 1, 2023
| }).map(List::toArray); | ||
| } | ||
|
|
||
| private static ScanQuery prepareScanQuery(@NotNull ScanQuery scanQuery) |
Contributor
There was a problem hiding this comment.
Can you please add a Javadoc for how we are preparing the scan query.
LakshSingla
reviewed
Nov 1, 2023
|
|
||
| private static ScanQuery prepareScanQuery(@NotNull ScanQuery scanQuery) | ||
| { | ||
| if (ScanQuery.Order.NONE.equals(scanQuery.getTimeOrder())) { |
Contributor
There was a problem hiding this comment.
I think we can optimize this further - Consider if we have a scan query without any ordering but with a limit. In that case, we don't need to set the limit to 0 to fetch the results. We can keep the limit as is.
Therefore instead of checking the timeOrder, we'd also need to check the ordering inside, and if its empty or not.
Contributor
Author
There was a problem hiding this comment.
Good catch! I've updated the condition
LakshSingla
approved these changes
Nov 2, 2023
Contributor
LakshSingla
left a comment
LakshSingla
left a comment
There was a problem hiding this comment.
LGTM, though I wonder if we can further optimize the change by planning the native query using #15241 and the MSQ query as is. However it would be difficult to generate the two plans and pass it to MSQ.
adarshsanjeev
added a commit
to adarshsanjeev/druid
that referenced
this pull request
Nov 2, 2023
…e#15301) While running queries on real time tasks using MSQ, there is an issue with queries with certain order by columns. If the query specifies a non time column, the query is planned as it is supported by MSQ. However, this throws an exception when passed to real time tasks once as the native query stack does not support it. This PR resolves this by removing the ordering from the query before contacting real time tasks. Fixes a bug with MSQ while reading data from real time tasks with non time ordering
cryptoe
pushed a commit
that referenced
this pull request
Nov 2, 2023
… (#15308) While running queries on real time tasks using MSQ, there is an issue with queries with certain order by columns. If the query specifies a non time column, the query is planned as it is supported by MSQ. However, this throws an exception when passed to real time tasks once as the native query stack does not support it. This PR resolves this by removing the ordering from the query before contacting real time tasks. Fixes a bug with MSQ while reading data from real time tasks with non time ordering
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
…e#15301) While running queries on real time tasks using MSQ, there is an issue with queries with certain order by columns. If the query specifies a non time column, the query is planned as it is supported by MSQ. However, this throws an exception when passed to real time tasks once as the native query stack does not support it. This PR resolves this by removing the ordering from the query before contacting real time tasks. Fixes a bug with MSQ while reading data from real time tasks with non time ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running queries on real time tasks using MSQ, there is an issue with queries with certain order by columns.
If the query specifies a non time column, the query is planned as it is supported by MSQ. However, this throws an exception when passed to real time tasks once as the native query stack does not support it. This PR resolves this by removing the ordering from the query before contacting real time tasks.
This PR has: