Skip to content

[Backport] fix physical memory detection on OSX (#15405) #15410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 1 commit into from
Nov 21, 2023
Merged

[Backport] fix physical memory detection on OSX (#15405) #15410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/bin/start-druid-main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ def get_physical_memory_linux():

def get_physical_memory_osx():
p1 = subprocess.Popen(['sysctl', '-a'], stdout=subprocess.PIPE)
p2 = subprocess.check_output(['grep', 'hw.memsize'], stdin=p1.stdout)
p2 = subprocess.check_output(['grep', 'hw.memsize:'], stdin=p1.stdout)
p2 = p2.decode('utf-8')
fields = p2.split(':')

Expand Down Expand Up @@ -394,7 +394,7 @@ def convert_total_memory_string(memory):
physical_memory = get_physical_memory()

if physical_memory is None:
raise ValueError('Please specify memory argument')
raise ValueError('Could not automatically determine memory size. Please explicitly specify the memory argument as --memory=<integer_value><m/g>')

return physical_memory
elif memory.endswith(MEM_MB_SUFFIX):
Expand Down