Skip to content

split jackson versions#15534

Closed
janjwerner-confluent wants to merge 2 commits intoapache:masterfrom
janjwerner-confluent:janjwerner-carve-out-snakeyaml
Closed

split jackson versions#15534
janjwerner-confluent wants to merge 2 commits intoapache:masterfrom
janjwerner-confluent:janjwerner-carve-out-snakeyaml

Conversation

@janjwerner-confluent
Copy link
Copy Markdown
Contributor

Description

Allow for bringing two separate versions of jackson dependencies.

  1. for druid processing / core that requires jackson 2.12
  2. for the remaining modules bring in updated 2.15 version

This change should hopefully help us move away from Snakeyaml 1.x in compile scope and keep it only as a test dependency.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@janjwerner-confluent janjwerner-confluent marked this pull request as draft December 11, 2023 16:33
Comment thread pom.xml
Comment on lines +101 to +102
<jackson.version>2.15.3</jackson.version>
<core.jackson.version>2.12.7.20221012</core.jackson.version>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we plan to go down that route, I would suggest we do it the other way around, upgrade core and make 2.15 the default. Explicitly depend on 2.12 for extensions that cannot upgrade.

@janjwerner-confluent
Copy link
Copy Markdown
Contributor Author

Closing this PR as I likely won't have the cycles to contribute to this approach.
The goal of removing Snakeyaml 1.x from the distribution should be achieved in #15549

@janjwerner-confluent janjwerner-confluent deleted the janjwerner-carve-out-snakeyaml branch December 13, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants