remove search auto strategy, estimateSelectivity of BitmapColumnIndex#15550
Merged
gianm merged 2 commits intoapache:masterfrom Dec 14, 2023
Merged
remove search auto strategy, estimateSelectivity of BitmapColumnIndex#15550gianm merged 2 commits intoapache:masterfrom
gianm merged 2 commits intoapache:masterfrom
Conversation
github-actions
Bot
added
Area - Documentation
Area - Segment Format and Ser/De
and removed
Area - Querying
labels
6 tasks
gianm
approved these changes
Dec 14, 2023
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
I'm ok with removing this. As far as I know, it's a rarely used feature, and removing it allows us to also remove estimateSelectivity and replace it with something better.
Contributor
|
Merging, given there was already a dev list thread about this. |
Contributor
|
@clintropolis Can you please update this change in the https://github.com/apache/druid/blob/master/docs/release-info/release-notes.md, in a follow-up PR as well? |
Member
Author
Why would I do that? I haven't seen any discussion that is part of the process unless I missed something... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the 'auto' strategy from the native search query to simplify
BitmapColumnIndexto remove theestimateSelectivitymethod. The 'auto' strategy is not on by default, and in some cases can be rather expensive since for logical filters like AND/OR we fetch all of the indexes, compute the cardinality of each of them, and then throw them away, sometimes to turn around and do the same thing again to actually use the indexes.The replacement for this will be smarter usage of indexes for all query types, as a follow-up I plan to bring the enhancements of #13977 to classic string typed columns, and I've got some additional improvements coming in the future.
Related dev mailing list thread
(This release note is currently a lie, but a follow-up PR will make it more true.)
Release note
The 'auto' strategy has been removed from the search query. Specifying 'auto' will now be equivalent to specifying 'useIndexes'. Improvements to how and when indexes are computed in general have allowed 'useIndexes' to benefit and be more adaptive when it uses indexes for filter processing, skipping computing expensive indexes when possible.
This PR has: