tidy up group by engines after removal of v1#15665
Merged
clintropolis merged 3 commits intoapache:masterfrom Jan 11, 2024
Merged
tidy up group by engines after removal of v1#15665clintropolis merged 3 commits intoapache:masterfrom
clintropolis merged 3 commits intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gianm
approved these changes
Jan 11, 2024
Member
Author
|
IT failure seems unrelated to changes in this PR |
LakshSingla
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up some stuff after the removal of group by v1 in #14866 so that stuff is a bit easier to follow. The biggest material change is that all common code of
GroupByQueryEngineV2that is used by both non-vectorized and vectorized engines has been moved intoGroupingEngine, including theprocessmethod which chooses which of non-vectorized and vectorized processing to use, and has been inlined into theprocessmethod ofGroupingEngine.Other changes:
GroupByQueryEngineV2has been renamed toGroupByQueryEngine, and now is totally focused on non-vectorized processing (since shared stuff has been moved intoGroupingEngineGroupByMergingQueryRunnerV2has been renamed toGroupByMergingQueryRunnerGroupByBinaryFnV2has been renamed toGroupByResultMergeFnThis PR has: