Implement task payload management with azure storage#15695
Merged
georgew5656 merged 2 commits intoapache:masterfrom Jan 18, 2024
Merged
Implement task payload management with azure storage#15695georgew5656 merged 2 commits intoapache:masterfrom
georgew5656 merged 2 commits intoapache:masterfrom
Conversation
YongGang
reviewed
Jan 17, 2024
| @Override | ||
| public Optional<InputStream> streamTaskPayload(String taskid) throws IOException | ||
| { | ||
| return streamTaskFile(taskid, 0, getTaskPayloadKey(taskid)); |
Contributor
There was a problem hiding this comment.
Seems the taskid is not used in streamTaskFile method thus can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement pushTaskPayload/streamTaskPayload for azure blob storage so mmless ingestion can run with larger ingestion payloads when using azure as the deep storage location.
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Currently, if you try running mmless ingestion with azure blob storage as the deep storage provider and use a task payload that is too large, the task logs will throw a NotImplementedException because the relevant functions are not implemented.
Release note
Support ingestion payloads larger than ~1MB for mmless ingestion on azure.
Key changed/added classes in this PR
AzureTaskLogsAzureTaskLogsTestThis PR has: