Skip to content

Fix comparator and remove deprecated methods from spectatorHistogram extension#15698

Merged
maytasm merged 3 commits intoapache:masterfrom
maytasm:followup-15340
Jan 18, 2024
Merged

Fix comparator and remove deprecated methods from spectatorHistogram extension#15698
maytasm merged 3 commits intoapache:masterfrom
maytasm:followup-15340

Conversation

@maytasm
Copy link
Copy Markdown
Contributor

@maytasm maytasm commented Jan 16, 2024

Fix comparator and remove deprecated methods from spectatorHistogram extension

Description

This is a followup to #15340 (review)
and include the following fixes:

  • Fix correct Comparator for double array type in SpectatorHistogramPercentilesPostAggregator
  • Remove deprecated methods from SpectatorHistogramAggregatorFactory

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@maytasm maytasm requested a review from clintropolis January 16, 2024 21:16
@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Jan 16, 2024
@maytasm
Copy link
Copy Markdown
Contributor Author

maytasm commented Jan 16, 2024 •
edited
Loading

CC: @bsyk

@maytasm maytasm merged commit a3b32fb into apache:master Jan 18, 2024
@maytasm maytasm deleted the followup-15340 branch January 18, 2024 05:59
maytasm added a commit that referenced this pull request Jan 18, 2024
@maytasm
Fix comparator and remove deprecated methods from spectatorHistogram …
e16939b 
…extension (#15698)

* Remove deprecated methods from SpectatorHistogram

* Remove deprecated methods from SpectatorHistogram

* Remove deprecated methods from SpectatorHistogram
maytasm added a commit to maytasm/druid that referenced this pull request Jan 18, 2024
@maytasm
Fix comparator and remove deprecated methods from spectatorHistogram …
b5f11c7 
…extension (apache#15698)

* Remove deprecated methods from SpectatorHistogram

* Remove deprecated methods from SpectatorHistogram

* Remove deprecated methods from SpectatorHistogram
@maytasm maytasm mentioned this pull request Jan 18, 2024
Merged
@clintropolis clintropolis added this to the Druid 29.0.0 milestone Jan 18, 2024
maytasm added a commit that referenced this pull request Jan 18, 2024
@maytasm
Fix comparator and remove deprecated methods from spectatorHistogram …
b587324 
…extension (#15698) (#15714)

* Remove deprecated methods from SpectatorHistogram

* Remove deprecated methods from SpectatorHistogram

* Remove deprecated methods from SpectatorHistogram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintropolis clintropolis clintropolis approved these changes

Assignees

No one assigned

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@maytasm @clintropolis