Remove index_realtime and index_realtime_appenderator tasks.#15717
Remove index_realtime and index_realtime_appenderator tasks.#15717gianm wants to merge 16 commits intoapache:masterfrom
Conversation
index_realtime tasks were removed from the documentation in apache#13107. Even at that time, they weren't really documented per se— just mentioned. They existed solely to support Tranquility, which is an obsolete ingestion method that predates migration of Druid to ASF and is no longer being maintained. Tranquility docs were also de-linked from the sidebars and the other doc pages in apache#11134. Only a stub remains, so people with links to the page can see that it's no longer recommended. index_realtime_appenderator tasks existed in the code base, but were never documented, nor as far as I am aware were they used for any purpose. This patch removes both task types completely, as well as removes all supporting code that was otherwise unused. It also updates the stub doc for Tranquility to be firmer that it is not compatible. (Previously, the stub doc said it wasn't recommended, and pointed out that it is built against an ancient 0.9.2 version of Druid.)
github-actions
Bot
added
Area - Documentation
Area - Batch Ingestion
Area - Segment Format and Ser/De
Area - Streaming Ingestion
Area - Ingestion
Area - MSQ
| @@ -46,8 +42,6 @@ public class RealtimeTuningConfig implements AppenderatorConfig | |||
| { | |||
| private static final Period DEFAULT_INTERMEDIATE_PERSIST_PERIOD = new Period("PT10M"); | |||
There was a problem hiding this comment.
I think most of these constants have been moved to SeekableStreamIndexTaskTuningConfig. Do we still need this class?
There was a problem hiding this comment.
Ah, no, we don't need it. I went through all the trouble of adjusting all the call sites to not use this, but then forgot to delete it. Fixed!
|
Hmm. |
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
Closed in favor of #16602. |
4 participants
index_realtimetasks were removed from the documentation in #13107. Even at that time, they weren't really documented per se— just mentioned. They existed solely to support Tranquility, which is an obsolete ingestion method that predates migration of Druid to ASF and is no longer being maintained. Tranquility docs were de-linked from the sidebars and other docs earlier, in #11134. Only a stub remains today, so people with links to the page can see that it's no longer recommended.index_realtime_appenderatortasks existed in the code base, but were never documented, nor as far as I am aware were they used for any purpose.Since they are both obsolete, this patch removes both task types completely, as well as removes all supporting code that was otherwise unused. It also updates the stub doc for Tranquility to be firmer that it is not compatible. (Previously, the stub doc said it wasn't recommended, and pointed out that it is built against an ancient 0.9.2 version of Druid.)
This patch also has some related metrics changes:
fireDepartmentMetrics.incrementProcessed()inSinglePhaseSubTask(this metric was not being emitted anyway)